Re: User Profile Modifications

I have taken your suggestions into consideration and modified the style sheet. This means there are no class assignments in the markup now. example: #profile dl dd { #profile dl dt { #profile dl { I've also applied the styling to the ID #notes like you pointed out. The patch script is here. http://digiflexdev.com/php/php-people-web.patch I'm not sure what you mean by "mix WS changes with real fixes". I've modified the markup file and style sheet file, right clicked chose Make Patch and sent that patch to you. If this is not how we do things here let me know the best approach, i'm only trying to help. Thanks. Paul Dragoonis. On Tue, Jun 30, 2009 at 9:31 AM, Hannes Magnusson < hannes.magnusson@gmail.com> wrote: > On Tue, Jun 30, 2009 at 14:10, Paul Dragoonis<dragoonis@gmail.com> wrote: > > The changes are now complete, the original tags are now in place with > extra > > styling to make it more appealing. > > Patch File: > > http://digiflexdev.com/php/php-people-web.patch > > Whats the point of adding the same class to all <dt> and another to all > <dd>? > Can't the CSS reference these directly? > If you think those styles will break other definition lists, then lets > add an ID on the <dl> element itself. > > + <h2 id="notes" style="color: #5A5993;">Notes:</h2> > This is totally useless, please move it into the css referencing the ID > > And please do not mix WS changes with real fixes, it makes it very > hard to review patches and track the history. > > -Hannes >