Re: User Profile Modifications
| From: | Paul Dragoonis | Date: | Tue, 30 Jun 2009 15:17:18 +0000 |
| Subject: | Re: User Profile Modifications | ||
| References: | 1 2 3 4 5 6 | Groups: | php.webmaster |
| Request: | Send a blank email to php-webmaster+get-5206@lists.php.net to get a copy of this message | ||
The dl's are breaking the floats, without the need for a "css clear" to stop
floating.
It was quite handy actually, otherwise we'd need to explicitly say "clear:
left" on an element.
This patch shows the definition changes not needing the 'dl', and removing
the '.defList' stuff from the bottom of the document.
http://digiflexdev.com/php/styles.css.patch
On the WS note i apologise there must be a way to tell my client to ignore
WS and newline changes.
Thanks.
Paul.
On Tue, Jun 30, 2009 at 11:02 AM, Hannes Magnusson <
hannes.magnusson@gmail.com> wrote:
> On Tue, Jun 30, 2009 at 16:17, Paul Dragoonis<dragoonis@gmail.com> wrote:
> > I have taken your suggestions into consideration and modified the style
> > sheet.
> > This means there are no class assignments in the markup now.
> > example:
> > #profile dl dd {
> > #profile dl dt {
> > #profile dl {
>
> Looks good.
> One hint, there is no need to use the 'dl' qualifier before dt ad dd,
> as it is already implied when using valid markup - and only cause
> extra work
>
>
> > I'm not sure what you mean by "mix WS changes with real fixes".
>
> WS stands for "Whitespace", adding/removing/changing
> spaces/tabs/newlines is very useless and unless clutters up the
> readability of the patches.
> - echo '<span property="foaf:name">', $NFO["name"],
> '</span>';
> + echo '<span property="foaf:name">' . $NFO["name"] .
> '</span>';
>
> This for example has no meaning what so ever.
> - <dd><a
> href="http://maps.google.com/?q=<?php echo $q
> ?>"><span
> property="geo:lat"><?php echo $PEAR["lat"]?></span>,
> <span
> property="geo:long"><?php echo
> $PEAR["long"]?></span></a></dt>
> + <a
> href="http://maps.google.com/?q=<?php echo $q
> ?>"><span
> property="geo:lat"><?php echo $PEAR["lat"]?></span>,
> <span
> property="geo:long"><?php echo
> $PEAR["long"]?></span></a>
> + </dd>
>
> I don't even know what is going on here.
>
> So, by mixing WS changes with real changes ("real changes" meaning
> stuff that matters) only causes frustration and steals precious time
> away from the reviewer.
>
>
> Quickly scanning the patch, why are you adding bunch of <dl>s?
>
>
> -Hannes
>