Re: User Profile Modifications

On Tue, Jun 30, 2009 at 16:17, Paul Dragoonis<dragoonis@gmail.com> wrote: > I have taken your suggestions into consideration and modified the style > sheet. > This means there are no class assignments in the markup now. > example: > #profile dl dd { > #profile dl dt { > #profile dl { Looks good. One hint, there is no need to use the 'dl' qualifier before dt ad dd, as it is already implied when using valid markup - and only cause extra work > I'm not sure what you mean by  "mix WS changes with real fixes". WS stands for "Whitespace", adding/removing/changing spaces/tabs/newlines is very useless and unless clutters up the readability of the patches. - echo '<span property="foaf:name">', $NFO["name"], '</span>'; + echo '<span property="foaf:name">' . $NFO["name"] . '</span>'; This for example has no meaning what so ever. - <dd><a href="http://maps.google.com/?q=<?php echo $q ?>"><span property="geo:lat"><?php echo $PEAR["lat"]?></span>, <span property="geo:long"><?php echo $PEAR["long"]?></span></a></dt> + <a href="http://maps.google.com/?q=<?php echo $q ?>"><span property="geo:lat"><?php echo $PEAR["lat"]?></span>, <span property="geo:long"><?php echo $PEAR["long"]?></span></a> + </dd> I don't even know what is going on here. So, by mixing WS changes with real changes ("real changes" meaning stuff that matters) only causes frustration and steals precious time away from the reviewer. Quickly scanning the patch, why are you adding bunch of <dl>s? -Hannes