Bug #75579 [Com]: All Interned Strings Free memory used and PHP crashes

From: Date: Thu, 21 Dec 2017 11:52:13 +0000
Subject: Bug #75579 [Com]: All Interned Strings Free memory used and PHP crashes
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-213205@lists.php.net to get a copy of this message 
Edit report at https://bugs.php.net/bug.php?id=75579&edit=1

 ID:                 75579
 Comment by:         post at minhost dot no
 Reported by:        post at minhost dot no
 Summary:            All Interned Strings Free memory used and PHP
                     crashes
 Status:             Analyzed
 Type:               Bug
 Package:            opcache
 Operating System:   CentOS 7.4
 PHP Version:        7.1.12
 Assigned To:        dmitry
 Block user comment: N
 Private report:     N

 New Comment:

I am not sure I completely understand you correct. However it makes me worry. Please note that the
first patch fixed the problem reported in this bug. Then I made a mistake in a reply, wich I
corrected in a new reply, confirming that is now works correct. File cache on disk works correct
with your first patch, it works correct and the same way as in PHP 7.1.11 wich do not have the bug.

So I don't understand what else you are trying to fix? The file cache on disk should be exactly
that, on disk, not in memory. And it works correct with your first patch.


Previous Comments:
------------------------------------------------------------------------
[2017-12-21 11:47:28] dmitry@php.net

It's going to load scripts cached in files into regular memory if SHM is full. Of course, it
would require more extra work on each request, but this should be cheaper then recompile everything.

------------------------------------------------------------------------
[2017-12-21 11:40:44] post at minhost dot no

@dmitry: Thank you for a new patch. But what are the new patch supposed to fix or improve? Because
the first patch seemed to work correct as explained in my previous reply.

Anyway, I will of course test you new patch, but I don't have time until several hours later.

------------------------------------------------------------------------
[2017-12-21 11:32:20] dmitry@php.net

Oh sorry, I posted invalid patch because of mess with branched.
This is the patch https://gist.github.com/dstogov/69e9a08038dcaf3c2e72ea4b1676242c

------------------------------------------------------------------------
[2017-12-21 09:50:06] post at minhost dot no

@dmitry: I have now tested in PHP 7.1.11, and the behaviour is the same as with PHP 7.1.13 RC1 +
your patch. When there is not enough memory left in opcache, then  new files will also not be cached
in file cache on disk. So that is not a bug.

I have tested your patch thorough now, and it seems to work correct, PHP no longer crashes. It
works! Please add your patch to the 7.x branch. It would be fantastic if we could get the patch
already in PHP 7.1.13 and PHP 7.0.27 in january 2018! Thanks!

------------------------------------------------------------------------
[2017-12-21 09:44:28] post at minhost dot no

@spam2: I am happy with the current way OOM and restart works. Every night opcache memory is
completely emptied anyhway when apache and php-fpm is reloaded. Also that discussion is off-topic to
this bug report.

------------------------------------------------------------------------


The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

    https://bugs.php.net/bug.php?id=75579


--
Edit this bug report at https://bugs.php.net/bug.php?id=75579&edit=1

Thread (52 messages)

« previous php.bugs (#213205) next »