Bug #75579 [Com]: All Interned Strings Free memory used and PHP crashes

From: Date: Thu, 21 Dec 2017 21:05:04 +0000
Subject: Bug #75579 [Com]: All Interned Strings Free memory used and PHP crashes
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-213229@lists.php.net to get a copy of this message 
Edit report at https://bugs.php.net/bug.php?id=75579&edit=1

 ID:                 75579
 Comment by:         post at minhost dot no
 Reported by:        post at minhost dot no
 Summary:            All Interned Strings Free memory used and PHP
                     crashes
 Status:             Closed
 Type:               Bug
 Package:            opcache
 Operating System:   CentOS 7.4
 PHP Version:        7.1.12
 Assigned To:        dmitry
 Block user comment: N
 Private report:     N

 New Comment:

@dmitry: I am frustrated to see you applied the patch to PHP 7.1.14 and not to PHP PHP 7.1.13 - We
have production servers with a lot of shared hosting clients running on PHP 7.1.11 - and now we will
not be able to upgrade before february 2018. Remember this bug completely makes PHP useless for us
that is using file cache as secondary fallback cache. Also remember I reported the bug already 27
november. I feel it is not a priority because you think not so many are using this setup. :(


Previous Comments:
------------------------------------------------------------------------
[2017-12-21 20:59:21] dmitry@php.net

@nikic, Sorry, I missed your last comment.
I think, the patch is OK.
If we have free SHM memory, "interned" strings are going to be allocated in additional
"SHM" blocks and then reused on next requests.
If there are no enough SHM, we fall back to process memory.

If you think, something is wrong, please, explain.

------------------------------------------------------------------------
[2017-12-21 20:49:31] dmitry@php.net

Automatic comment on behalf of dmitry@zend.com
Revision: http://git.php.net/?p=php-src.git;a=commit;h=37bf8bdc1494abb2ce5cac40e0be80e23682f851
Log: Fixed bug #75579 (Interned strings buffer overflow may cause crash)

------------------------------------------------------------------------
[2017-12-21 20:38:10] nikic@php.net

@dmitry: With your latest patch, if the interned string buffer is full, but SHM is not full,
won't we end up repeatedly allocating SHM memory that's not going to be used?

------------------------------------------------------------------------
[2017-12-21 17:10:48] post at minhost dot no

@dmitry: I have now tested your newest patch against PHP 7.1.13RC1, and I did not find any problems.
PHP does not crash. The behaviour seemed to be the same as with your previous patch. Anyway, it
seems to work fine! Can you please apply your newest patch to the 7.x branch? I expect it will be
applied to all of PHP 7.0.x, 7.1.x and 7.2.x? Hopefully it will be in time for the release of PHP
7.0.27 and 7.1.13? Thanks!

------------------------------------------------------------------------
[2017-12-21 12:05:14] post at minhost dot no

Ok, thanks for explainging it to me, @dmitry. Sorry I misunderstood the change. I will test your
newest patch later tonight, and let you know if it works correct for me.

------------------------------------------------------------------------


The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

    https://bugs.php.net/bug.php?id=75579


--
Edit this bug report at https://bugs.php.net/bug.php?id=75579&edit=1

Thread (52 messages)

« previous php.bugs (#213229) next »