Re: Could some kind soul review these patches please.
| From: | Sascha Schumann | Date: | Thu, 07 Dec 2000 10:07:08 +0000 |
| Subject: | Re: Could some kind soul review these patches please. | ||
| References: | 1 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-40338@lists.php.net to get a copy of this message | ||
On Thu, 7 Dec 2000, Sam Liddicott wrote:
> Could some kind soul review these patches please.
>
> The first patch adds apache_child_terminate() to the apache sapi module to
> match the apache api call ap_child_terminate() and applies to the
> sapi/apache directory (path not in the patches). This is important if a
> script knows it has caused a LOT of memory to be allocated for the process -
> such as for a LARGE query, or LARGE image etc, and wishes it to be returned
> to the underlying OS.
>
> The second patch fixes ext/ext_skel so it works on solaris /bin/sh; it was a
> problem with missing ""
Thanks, I've applied the second patch. Please use unified
diffs (diff -u) the next time.
The option to terminate the Apache child should be made
optional. As an ISP, I would not like my customers to simply
be able to kill Apache by using one function call.
- Sascha