RE: [PHP-DEV] Could some kind soul review these patches please.

> -----Original Message----- > From: Sascha Schumann [mailto:sascha@schumann.cx] > Sent: Thursday, December 07, 2000 11:24 > To: Sam Liddicott > Cc: php-dev@lists.php.net > Subject: RE: [PHP-DEV] Could some kind soul review these > patches please. > > > If it seems agreeable I will extend the patch to be enabled with > > --enable-apache-child-terminate and to have the various > configuration > > capabilities which will be a good learning er... > experience.. for me. > > You just need to add a PHP_INI_ENTRY in php_apache.c and a > new property to the php_apache_info_struct in mod_php4.h. > Your function can then query the property to determine > whether it should do what it is supposed to do. Sound advice; thanks - and very helpful. It seems like all the other apache sapi code uses r->per_dir_config to get the settings. It seems like there are no other ->per_xxx_config types Is per_dir_config made up from the combination of <location <file <dir <vhost etc sections in httpd.conf?; am I safe sticking with that to read the "current" value from? Also - we don't want users to be able to change this, how to I mark it as a php_admin_flag instead of a php_flag? PHP_INI_SYSTEM is described as allowing it only to exist in the ini file, and PHP_INI_ALL as exiting anywhere; but I suspect this is a documentation error and that PHP_INI_SYSTEM marks it as an admin flag, am I right? Thanks Sam