RE: [PHP-DEV] Could some kind soul review these patches please.

It should probably be an INI directive, with permissions of PHP_INI_SYSTEM, so that it can be modified in the php.ini and .conf files (through admin_flag) only. At any rate, I'd put this patch in the 4.0.5 tree only, I don't think it's pressing for 4.0.4. Zeev At 12:22 7/12/2000, Sam Liddicott wrote:

-----Original Message----- From: Sascha Schumann [mailto:sascha@schumann.cx] Sent: Thursday, December 07, 2000 10:07 To: Sam Liddicott Cc: php-dev@lists.php.net Subject: Re: [PHP-DEV] Could some kind soul review these patches please.

    The option to terminate the Apache child should be made
    optional. As an ISP, I would not like my customers to simply
    be able to kill Apache by using one function call.

Good point. Do you think it should be a configure-time option as with: --enable-apache-child-terminate or a php runtime configuration option. Perhaps with disable_functions, or maybe on a per <vhost, per <location, per <files basis? so that various webs, web parts or files may have this capability. I think I prefer both; If it seems agreeable I will extend the patch to be enabled with --enable-apache-child-terminate and to have the various configuration capabilities which will be a good learning er... experience.. for me. Sam -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, e-mail: php-dev-unsubscribe@lists.php.net For additional commands, e-mail: php-dev-help@lists.php.net To contact the list administrators, e-mail: php-list-admin@lists.php.net

-- Zeev Suraski <zeev@zend.com> CTO, Zend Technologies Ltd. http://www.zend.com/