RE: [PHP-DEV] Could some kind soul review these patches please.

> It seems like all the other apache sapi code uses r->per_dir_config to get > the settings. > It seems like there are no other ->per_xxx_config types > Is per_dir_config made up from the combination of <location <file <dir > <vhost etc sections in httpd.conf?; am I safe sticking with that to read the > "current" value from? Within a normal PHP function, you should be able to simply access the global php_apache_info structure. The framework takes care of setting the appropiate entries in that structure, depending on the Apache context. > Also - we don't want users to be able to change this, how to I mark it as a > php_admin_flag instead of a php_flag? > PHP_INI_SYSTEM is described as allowing it only to exist in the ini file, > and PHP_INI_ALL as exiting anywhere; but I suspect this is a documentation > error and that PHP_INI_SYSTEM marks it as an admin flag, am I right? Right. That is at least the way it is implemented in the Apache 2.0 filter. I think the Apache 1.3 handler does the same thing. - Sascha