Re: [RFC] Deprecations for PHP 7.3

Hi! > This RFC collects a number of deprecations for PHP 7.3 which I consider to > be too minor to warrant a separate proposal. However, each deprecation will > still be voted separately. > > https://wiki.php.net/rfc/deprecations_php_7_3 > Undocumented mbstring function aliases Not sure what this would give us. Yes, they are undocumented, but do they hurt anything? > String search functions with integer needle That is definitely weird. However, I am not sure what should happen in non-integer cases - i.e. what happens if I pass a double? Or a boolean? > fgetss() function and string.strip_tags filter I think I disagree with "strip_tags() itself, due to its limitations and known bugs, already has very few legitimate applications" and certainly the manual does not have any notice to that effect. I am not sure what is the reason to remove this functionality, would like to hear more about it - and it doesn't seem so minor as to be 1/4 of the RFC. If I had to vote today, I'd probably vote no just on this point. It may be true that strip_tags() alone without streaming part could be implemented easier. However, that is not a reason to drop functionality by itself, unless it's already completely broken. If it is, I'd like to hear more about it. > Defining a free-standing assert() function Sounds good. -- Stas Malyshev smalyshev@gmail.com