Re: [RFC] Deprecations for PHP 7.3

On Tue, Jun 26, 2018 at 9:51 PM, Kalle Sommer Nielsen <kalle@php.net> wrote: > Den tir. 26. jun. 2018 kl. 20.16 skrev Nikita Popov <nikita.ppv@gmail.com > >: > > Feel free to add this one to the RFC, if you know what the background > for the deprecation is. Given that the manual already marks it as > deprecated for so long, this seems like a mere technicality. > > I added the pdo_odbc.db2_instance_name to the RFC including 2 options > which is up to you to decide for with the relevant patches included. > Thanks for adding it. Unless there is a particular reason to rush here, I'd suggest to follow the usual process and formally deprecate the option prior to removal. As a clarification, what is the alternative to using this ini setting? I guess you can just explicit set the DB2INSTANCE env var, but that probably has the same issues. Is there a "correct" way to do this? (Sorry if it's obvious, I'm not familiar with ODBC.) > > Given the recent discussions about having a PHP 7.4 release for > additional deprecations, I'm going to punt on the rest. While they may be > no-brainers to you and I, a lot of those are actually quite controversial > (e.g. there was an RFC to deprecate b' in 7.2 and it was declined -- go > figure!) > > > > I'd suggest that you already open up the next deprecation RFC, to make > sure these are not forgotten. Some of them should probably get separate > proposals altogether (especially the var interpolation syntax). > > > > Nikita > > I agree that a lot of them are controversial, and perhaps its a good > idea to start flesh them out for our users and fellow contributors > already now. I began a draft based on your 7.3 RFC for 7.4[1]. Ps I > took the liberty of adding your name as the RFC author. > > [1] https://wiki.php.net/rfc/deprecations_php_7_4 > Thanks! Nikita