Re: [RFC] UString

Hi Florian, On Mon, Mar 2, 2015 at 5:57 AM, Florian Margaine <florian@margaine.com> wrote: > Le 1 mars 2015 21:26, "Derick Rethans" <derick@php.net> a écrit : > > > > Hey Joe, > > > > I think there are a few issues with the proposal, although I like the > > general idea. I've had the tab with the RFC open since October... but > > never looked at it until now :-/. So, a few comments: > > > > - UString as a name. > > > > I think I am going to prefer "Text" as a class name. Unicode (and > > intl/icu) have lots of operators acting on items containing unicode > > strings. But they are really pieces of text. For example sentences, word > > break iterators, etc. UString *feels* clunky, and not "standard". If > > it's going to be part of PHP core, then we should pick a "core" name. (I > > might prefer String, but that's going to cause a whole lot of issues > > obviously). > > Isn't this "solved" if we use \php\String? > I suppose we need "Context Sensitive Lexer" for "String", but I guess it passes. Let's use namespace for new internal classes at least. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net