Re: [PEPr] Call for votes on Authentication::Auth_HTTP_Digest
| From: | Rui Hirokawa | Date: | Sun, 29 Feb 2004 05:01:22 +0000 |
| Subject: | Re: [PEPr] Call for votes on Authentication::Auth_HTTP_Digest | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-25971@lists.php.net to get a copy of this message | ||
I replaced tab with spaces and made a unified diff.
http://www.geocities.jp/rui_hirokawa/php/scripts/Auth_HTTP-digest.patch.gz
On Sat, 28 Feb 2004 19:43:11 +0100
Martin Jansen <mj@php.net> wrote:
> On Sat Feb 28, 2004 at 11:2201PM +0900, Rui Hirokawa wrote:
> > I just made Auth_HTTP.php including HTTP Digest Authentication.
> >
> > Auth_HTTP:
> >
> > http://www.geocities.jp/rui_hirokawa/php/scripts/HTTP.php.txt
> > sample file for digest authentication:
> >
> > http://www.geocities.jp/rui_hirokawa/php/scripts/test-digest.php.txt
> >
> > I believe that the basic authentication works just as the current
> > version and it has same API.
>
> Yeah, that looks fine. But it looks like tabs instead of spaces are used
> for indentation. Is it possible that you fix that and generate a unified
> diff ("diff -u HTTP.php") afterwards? This way it's more easy to spot
> the changes.
>
> > I would cancel my proporsal for Auth_HTTP_Digest at pepr.
>
> Sounds like the way to go [tm].
--
Rui Hirokawa <rui_hirokawa@ybb.ne.jp>