Re: [PEPr] Call for votes on Authentication::Auth_HTTP_Digest
| From: | Martin Jansen | Date: | Wed, 03 Mar 2004 07:13:23 +0000 |
| Subject: | Re: [PEPr] Call for votes on Authentication::Auth_HTTP_Digest | ||
| References: | 1 2 3 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-26048@lists.php.net to get a copy of this message | ||
On Sun Feb 29, 2004 at 02:0122PM +0900, Rui Hirokawa wrote:
> I replaced tab with spaces and made a unified diff.
>
>
> http://www.geocities.jp/rui_hirokawa/php/scripts/Auth_HTTP-digest.patch.gz
Looks cool. A few points though:
- Can you replace the usage of apache_request_headers() with
getallheaders()?
This way the code will also work with PHP < 4.3.0.
- At some places you did not follow the coding standards strictly.
(This can be fixed once the digest authentication is in CVS.)
- return PEAR::raiseError('authMethod is invalid.');
should be something like
return PEAR::raiseError('Invalid HTTP authentication method.');
- I really do not like the fact that the database is accessed directly
in login(). Isn't there an easy way to handle this inside the storage
containers?
--
- Martin Martin Jansen
http://martinjansen.com/