Re: Re: [PEPr] Comment on Date and Time::Date_Holidays

Carsten, Carsten Lucke wrote:

Hi, PEPr wrote:

Antônio Carlos Venâncio Júnior (http://pear.php.net/user/antonio) has commented on the proposal for Date and Time::Date_Holidays. Comment: Are you planning to add support to differentiate national/state/city holidays?

Yes, I thought that there could be drivers for several countries. If there are stated in those countries, that differ in many points from the country's holidays, IMO an own driver for the state should be written. And so on ...

no problem with that. I see that this approach should handle that. Just don't forget to add support for this kind of peculiarity on the parent Driver and document how that should be implemented for each country. Anyways I can be responsible for the pt_BR driver (aka Brazil.php). And you can get some inspiration here: ---------- http://search.cpan.org/~jonasbn/Date-Holidays-Abstract-0.03/lib/Date/Holidays/Abstract.pm http://search.cpan.org/~jonasbn/Date-Holidays-Super-0.02/lib/Date/Holidays/Super.pm http://search.cpan.org/~jonasbn/Date-Holidays-0.02/lib/Date/Holidays.pm ---------- It's nice to look at Date::Holidays::DE, Date::Holidays::DK, Date::Holidays::FR, Date::Holidays::NO, Date::Holiday::PT and Date::Holidays::UK too. ;)

Regards, Carsten -- Ate' Antonio echo antonio php net | sed 's/ /@/;s/ /./g' FreeBSD/OpenBSD/Solaris | PHP/MySQL/Python | PGP Key ID 0x5BBEB073 "Can't buy what I want because its FREE!" - Pearl Jam