Re: [PEPr] Comment on Networking::Monitor
| From: | Robert Peake | Date: | Thu, 09 Dec 2004 18:04:39 +0000 |
| Subject: | Re: [PEPr] Comment on Networking::Monitor | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-34966@lists.php.net to get a copy of this message | ||
Hi Bertrand,
Yes -- I will double-check CS before moving to vote.
s/if(/if (/g <- my best friend :)
Why do you recommend foreach instead of while ... each?
Best,
Robert
Bertrand Mansion wrote:
Bertrand Mansion (http://pear.php.net/user/mansion) has commented on the proposal for Networking::Monitor. Comment: This looks good. Could you try to be more consistent in your PHPDoc blocks and fix some CS issues, for example check where you put brakets and parenthesis if () not if(), function () { not function () { Try to use foreach() instead of while (list = each). Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=171