[PEPr] +1 for Networking::Monitor
| From: | Justin Patrin | Date: | Thu, 16 Dec 2004 18:42:13 +0000 |
| Subject: | [PEPr] +1 for Networking::Monitor | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-35111@lists.php.net to get a copy of this message | ||
Justin Patrin (http://pear.php.net/user/justinpatrin) has voted +1 on the proposal for
Networking::Monitor.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=171
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=171&handle=justinpatrin
This vote is conditional. The condition is:
Great job overall. :-) I think this this package will be very useful.
NULL should be null
More whitespace separating blocks (i.e. an empty line after each function)
Docblocks for each member var which describe what it is for
Functional descriptions of each parameter and return value in function docblocks
If you include the var name in @var and @param docblocks, a $ should be prepended to the name
In Service.php, use single quotes for "not yet implemented" ;-)
Pear should be PEAR in Net_Monitor_Service_FTP::check
(Optional) In Net_Monitor_Service_SMTP::check I would prefer the if blocks to be switched (i.e.
don't use a ! in the if()). (I know that this is a very nit-picky kind of thing, it's just
a suggestion. It makes sense IMHO, though.)
--
Sent by PEPr, the automatic proposal system at http://pear.php.net