Re[2]: [PEAR-DEV] Re: [PEPr] +1 for Images::XBM
| From: | Evgeny Stepanischev | Date: | Wed, 02 Mar 2005 17:27:48 +0000 |
| Subject: | Re[2]: [PEAR-DEV] Re: [PEPr] +1 for Images::XBM | ||
| References: | 1 2 3 4 5 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-36477@lists.php.net to get a copy of this message | ||
>> Ok, I see your point. However, when/if GD extension gets a OO
>> implementaion, I doubt that it will keep the "image" prefix used in
>> procedural context... I won't hold it against you ;-)
>>
>> Unless a lot of people wish to see the name changes I proposed, don't
>> bother changing them for now then...
>>
JP> I agree with Phillipe. It doesn't make sense to include the "image"
JP> prefix in these functions. Just because this is the way GD does it
JP> doesn't mean we have to do it that way.I would much rather our
JP> implementation(s) have useful names instead of throwbacks to the
JP> non-OO way of doing things. $image->image* just reiterates the
JP> namespace, it has no real value.
JP> I also agree with the funciton renamings he suggested (getWidth,
JP> getHeight, etc).
Okay, I put new version in few minutes.