Re: [PEPr] +1 for Images::XBM
| From: | Evgeny Stepanischev | Date: | Wed, 02 Mar 2005 18:12:58 +0000 |
| Subject: | Re: [PEPr] +1 for Images::XBM | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-36482@lists.php.net to get a copy of this message | ||
AK> few minor CS fixes
AK> * your constants should be prefixed IMAGE_XBM_ not just XBM
Fixed.
AK> * a few short if statements (always use the { }), and the
AK> alightment of multiline conditions is a little odd (add more,
AK> rather than less indentation)
Fixed
AK> * @include can be a point of much fustration. - it's usually
AK> a programming error / eg. not installed), rather than a runtime
AK> error...
Fixed.
--
Kind regards,
Evgeny Stepanischev