[PEPr] Comment on XML::XML_Feed_Writer

James Stewart (http://pear.php.net/user/jystewart) has commented on the proposal for XML::XML_Feed_Writer. Comment: I've just spent some more time looking through this code and I can't quite see how it works. The atom0.3.php file doesn't contain a class and isn't called at all from your XML_Feed_Writer class. I'm presuming that this isn't intended as production code, but it would be useful to have a better idea of how it's meant to fit together if we're to vote on the implementation. It would be good for any feed writer module released to contain full support for Atom 1.0 (which was approved this week), and for that to include checks to ensure that the XML generated was valid Atom. The current implementation does not guarantee valid Atom 0.3 feeds. The saveRSS function should be called something like saveFeed if the package is to handle more than just RSS, and it might be simpler to break that function up so you have one function which generates the feed/DOM object, and then others which handle saving/return a string. It may also be useful to include some extra abstractions/mappings so that users can send the same data to the package and retrieve it in various feed formats. The number of entries should not be limited to 50. The Atom spec doesn't specify any such limit. You may also want to change references to RDF0.92 to RSS0.92, which is the correct name for that format, but I'm guessing there'll be little demand for support for RSS<1.0 anyway. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=258 -- Sent by PEPr, the automatic proposal system at http://pear.php.net