[PEPr] Comment on HTML::HTML_TagCloud
| From: | Olivier Guilyardi | Date: | Wed, 14 Jun 2006 10:42:20 +0000 |
| Subject: | [PEPr] Comment on HTML::HTML_TagCloud | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-42932@lists.php.net to get a copy of this message | ||
Olivier Guilyardi (http://pear.php.net/user/olivierg) has commented on the proposal for
HTML::HTML_TagCloud.
Comment:
Very nice !
Remarks :
- the strtotime() calls in TagCloud_example1.php fail on my system (PHP
4.4.2), the "YYYYMMDDHHMMSS" format does not seem to be supported with my
version of PHP (btw, please use quotes around strings...). "YYYY-MM-DD"
works fine.
- your properties/methods naming scheme is not consistent. Example :
$basefontsize, $_max_epoc, addElement(). Why dont you stick with the
fooBar syntax ?
- I personally dislike public properties. One day or the other that ends
up with breaking BC. IMO, options arrays (passed as method arguments) or
setters/getters are better.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=399
--
Sent by PEPr, the automatic proposal system at http://pear.php.net