Re: [PEPr] Comment on HTML::HTML_TagCloud

You should probably use percentages for the font-size.. this way it will be relative to the container element's font-size.. Evert Justin Patrin wrote:

Justin Patrin (http://pear.php.net/user/justinpatrin) has commented on the proposal for HTML::HTML_TagCloud. Comment: Please be consistent with your quote usage. For example: "<style type=".'"text/css">'."\n"; There is no reason for the initial " string. '<style type="text/css">'."\n"; I would prefer ' for all strings as it is generally faster ("\n" and similar are excepted of course). See: http://pear.reversefold.com/strings/ See the above link also for the speed difference between ' and " when concatenating variables. ' is always faster. Do not use sprintf for simple concatenation (%s). It is far slower than any other method and is simply not needed (printf should only be used for heavy formatting). Looks good otherwise. :-) Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=399