[PEPr] Comment on HTML::HTML_TagCloud
| From: | Olivier Guilyardi | Date: | Thu, 15 Jun 2006 13:51:08 +0000 |
| Subject: | [PEPr] Comment on HTML::HTML_TagCloud | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-42959@lists.php.net to get a copy of this message | ||
Olivier Guilyardi (http://pear.php.net/user/olivierg) has commented on the proposal for
HTML::HTML_TagCloud.
Comment:
There's a small bug : the second argument of the constructor
($fontsizerange) has no effect.
You forgot to assign the corresponding property. Add :
$this->fontsizerange = $fontsizerange;
I also modified _createHTMLTag, to not use <span>, and to add a space at
the end of line (that's for IE ; otherwise words are not spaced enough).
That's the way they do at flickr.com :
function _createHTMLTag($tag, $type, $fontsize){
return sprintf("<a class=\"%s\" style=\"font-size: %d%s\"
href=\"%s\">%s</a> \n",
You still need to change the CSS generation routines accordingly...
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=399
--
Sent by PEPr, the automatic proposal system at http://pear.php.net