Re: Re: [PEPr] Comment on HTML::HTML_TagCloud

Hi Pierre & Martin On 6/16/06, Pierre <pierre.php@gmail.com> wrote:

On Fri, 16 Jun 2006 08:38:44 +0200 mj@php.net (Martin Jansen) wrote:

Or do you mean the lack of public/private declaration?

Yes, I was referring to the syntax. This is why the package is not E_STRICT compliant at all. It is, well, almost (see below)

You do not have to use public/private declaration to be E_STRICT compliant, same for the "var" declaration. And as far as I can see, this code is E_STRICT compliant. So take #2, what are you refering too exactly? Running under PHP6 I get 2 E_STRICT warnings (and dozen E_NOTICEs)

running example2. PHP Strict Standards: Assigning the return value of new by reference is deprecated in /usr/home/bjori/HTML_TagCloud-0.0.1/docs/examples/TagCloud_example2.php on line 9 This is due to the usage of =& new.. in the example, which PHP5 users obviously won't use. PHP Strict Standards: Non-static method HTML_TagCloud::_cmpElementsName() cannot be called statically in /usr/home/bjori/HTML_TagCloud-0.0.1/TagCloud.php on line 320 This however is another matter, but most definitely be easily fixed. PHP Notice: Undefined index: timestamp in /usr/home/bjori/HTML_TagCloud-0.0.1/TagCloud.php on line 365 And this has nothing to do with E_STRICt, probably just a simple oversight.

I do. I know that this is controversial and that I will tick people of, but if we ever want to make any progress with regards to helping PHP 5 gain ground, we should stop adding new PHP 4 packages. I do not see any reasons to stop adding PHP4 packages now. PHP4 is still more than 90% of the install base. Change this fact and we will automagically have only PHP5 new packages. Rules or regulations do not work here, natural move does. I don't understand why PEAR people still support PHP 4 despite the fact that our "mothership" has released PHP 5.0.0 nearly two years ago. Don't get me wrong, I hate those bloody PHP4 packages - but in those

cases were the package can run under PHP4 without massive modification I am all for it, but the primary goal should of course to take advantage of the new OO model, WHEN it makes sense. In this case, I can't see any reason for why this package shouldn't be PHP4 compatible. (I admittedly haven't really looked at the package, only ran the examples).

Let's give people a reason to get their asses up and upgrade to PHP 5. It's about time. Indeed, and I'm one the first to use php5 for all my new devs. However using syntax sugars for using syntax sugar is pointless. -- Pierre -- PEAR Development Mailing List (http://pear.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php