[PEPr] Comment on HTML::HTML_TagCloud
| From: | Mark Wiesemann | Date: | Wed, 19 Jul 2006 19:11:42 +0000 |
| Subject: | [PEPr] Comment on HTML::HTML_TagCloud | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-43534@lists.php.net to get a copy of this message | ||
Mark Wiesemann (http://pear.php.net/user/wiesemann) has commented on the proposal for
HTML::HTML_TagCloud.
Comment:
Can you please remove the file tag for the TGZ file from the package.xml
file? I can't install the package because of this entry.
In the examples files, please use
require_once 'HTML/TagCloud.php';
instead of
require_once '../../TagCloud.php';
Not sure: do private properties still need to be prefixed with an
underscore for PHP5-only code?
Personal preference: Names with camel caps are easier to read, e.g.
$fontSizeRange instead of $fontsizerange.
CS (Coding Standards):
- try to make a linebreak after max. 80 characters
- the opening bracket ({} needs to be at the beginning of the next line
Nit-picky thing: s/PHP versions 5/PHP version 5/ in the header comment
block.
About the license: Is there a reason for not using version 3.01 instead of
3.0 of the PHP License?
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=399
--
Sent by PEPr, the automatic proposal system at http://pear.php.net