[PEPr] Comment on HTML::HTML_TagCloud
| From: | Mark Wiesemann | Date: | Tue, 25 Jul 2006 09:35:35 +0000 |
| Subject: | [PEPr] Comment on HTML::HTML_TagCloud | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-43563@lists.php.net to get a copy of this message | ||
Mark Wiesemann (http://pear.php.net/user/wiesemann) has commented on the proposal for
HTML::HTML_TagCloud.
Comment:
Apart from minor spacing issues like
if($this->baseFontSize - $this->fontSizeRange > 0){
or
foreach($this->epocLevel as $item){
this looks good now, nice work.
BTW: If you use these funny function separators (don't know how they are
really called), you should keep them in sync with the real prototypes,
e.g.:
// {{{ private _createHTMLTag($tagname, $epocLevel, $fontSize)
protected function _createHTMLTag($tag, $type, $fontSize)
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=399
--
Sent by PEPr, the automatic proposal system at http://pear.php.net