Re: [PEPr] Comment on Authentication::NTLMProxy

Hello, On 27 Jun 2006 18:54:13 -0000, Justin Patrin <papercrane@reversefold.com> wrote:

Even if you don't do this, why not use Net_Socket instead of using low-level socket manipulation functions?

Why using it is a more appropriate question. I see no pros to use net_socket. It only adds more bottlenecks and complexity to something we should keep small and simple. Keeping compatibility with some old php versions is not a good thing either, the risk to have many WTF factors while using it can be too high.

You need to explain this in more detail. The script should be able to exit on its own, shoudl it not? If you write your code to return instead of die then the calling script can end and nothing untoward shoudl happen. The exit() calls are needed during the NTLM handshake. You keep saying this but never explain why. Why should this be needed? Why won't letting the script end normally work?

I really suggest to read the (nearly non existent) specs about NTLM.

The log is a decent I idea, but I suggest you use the Log package

instead

as it would allow the developer to log however they want to.

I do not want a bloated class. Sorry, that's not a good reason, especially since supporting Log would add only a few lines of code. Your current log functionality only appends to a string. Allowing someone to use Log would be far more flexible. You don't even have to add any extra explicit support for this. Simple allow the developer to pass in a Log instance if they with to log and, instead of appending to an internal string check for a log object, then call $this->log->log(). Only a few extra lines of code for a far more flexible logging mechanism.

I agree here, if there is any log system, Log should be used. It is a good packages and "bloated" really does not apply to it. --Pierre