Re: [PEPr] -1 for Authentication::NTLMProxy

On 7/5/06, Justin Patrin <papercrane@gmail.com> wrote:

Maintenance is decreased when you *don't duplicate code*.

Maintenance is impossible when you add three external packages to solve a problem covered by a dozen of lines in your code.

Easiness is also a false argument in this case. using HTTP_Request internally will not increase the complexity of the external interfaces of this class and could even make it more consistent with other PEAR packages. In fact, using HTTP_Request will actually *reduce* complexity by making the code for this package simpler

Reduce which complexity? The package is damned simple and ... works.

No, it is not ridiculous. One of the basic tenets of PEAR is code reuse. To reimplement HTTP code is what is ridiculous. If you have a problem with HTTP_Request and Net_Socket try contributing some patches to make them more efficient instead of trolling.

If you want me to be honest, net_socket should be droped and we should only rely on php functions (stream or files), at least for php5+ and in some extends 4.3+ (like here). HTTP_Request should be used for complex cases, this situation is anything you want but complex (from a http pov).

I am entitled to my own opinion and my own vote.

Yes, and please don't try to create rules from your opinions. Anyway, we are in the votes phase, we are arguing in circle. --Pierre