[PEPr] Comment on Versioning::PCVS

Alan Knowles (http://pear.php.net/user/alan_k) has commented on the proposal for Versioning::PCVS. Comment: Please check the coding standards - Method Naming - Variable naming (please dont use $_xxx as local vars) - missing { } = eg. using short if's - Try reducing your code nesting (drop out and return first in methods). eg. function x() { if (!xxx){ return error.. } .... body of code... } - you should be coding to PHP5 for new proposals - use statics rather than globals. - documenting local vars is a bit odd.. - please use escapeShellCmd/Arg etc. to escape your command line! - potentialy a huge security hole.... Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=453 -- Sent by PEPr, the automatic proposal system at http://pear.php.net