[PEPr] Comment on Versioning::Versioning_CVS
| From: | Alan Knowles | Date: | Mon, 20 Nov 2006 02:55:03 +0000 |
| Subject: | [PEPr] Comment on Versioning::Versioning_CVS | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-44972@lists.php.net to get a copy of this message | ||
Alan Knowles (http://pear.php.net/user/alan_k) has commented on the proposal for
Versioning::Versioning_CVS.
Comment:
require_once 'PEAR/Versioning/Versioning_CVS/CVS_Extension.php'
should be
require_once 'Versioning/CVS/Extension.php'
-----------
if (PEAR::isError(($entries = $this->getEntries()))) {
return false;
}else {
... <- else is not needed.. there is no other code flow..
Similarly with this.
if($execType>3 || $execType<0) {
break;
} else {
can you check CS - I think if() needs a space after the f.
------------
is _pre() actualy used anywhere?
-----------------
Is PEAR_Exception not the standard now?
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=453
--
Sent by PEPr, the automatic proposal system at http://pear.php.net