Re: [PEPr] Comment on Versioning::PCVS

Thx Alan, Justin and Clay i'am very new to PEAR, so i don't know much over naming conventions, only the stuff i read in the documentation of PEAR. I will have a look on your hints. Also i have some other questions. I read the other comments on my proposal. First i got a naming problem in my PEAR package. Now my class called Versioning_PCVS. But i saw another category called VersionControll. But it seems to me a bit too long. So i took a new category for my package. Can you give me some hints about naming the class? And i wanna know, if there is a software that creates the package.xml for me, or have i edit this by hand? Regrads, Markus Niewerth >Alan Knowles (http://pear.php.net/user/alan_k) has commented on the proposal for >Versioning::PCVS. > >Comment: > >Please check the coding standards >- Method Naming >- Variable naming (please dont use $_xxx as local vars) >- missing { } = eg. using short if's >- Try reducing your code nesting (drop out and return first in methods). >eg. >function x() > { > if (!xxx){ > return error.. > } > .... body of code... >} > >- you should be coding to PHP5 for new proposals - use statics rather than >globals. >- documenting local vars is a bit odd.. >- please use escapeShellCmd/Arg etc. to escape your command line! - >potentialy a huge security hole.... > >Proposal information: >http://pear.php.net/pepr/pepr-proposal-show.php?id=453 > >-- >Sent by PEPr, the automatic proposal system at >http://pear.php.net >