Re: [PEPr] Comment on Versioning::Versioning_CVS

Hi Alan, ---------- Original Message ---------------------------------- From: "Alan Knowles" <alan@akbkhome.com> Date: 20 Nov 2006 02:55:03 -0000 > >Alan Knowles (http://pear.php.net/user/alan_k) has commented on the proposal for >Versioning::Versioning_CVS. > >Comment: > >require_once 'PEAR/Versioning/Versioning_CVS/CVS_Extension.php' >should be > >require_once 'Versioning/CVS/Extension.php' >----------- This "don't" work on machines that works with CVS. Cause the administrative files are in this directory. So there must be a workaround for this problem. It's not usefull to put source files in a CVS folder?! > if (PEAR::isError(($entries = $this->getEntries()))) { > return false; > }else { > ... <- else is not needed.. there is no other code flow.. > >Similarly with this. >if($execType>3 || $execType<0) { > break; > } else { > >can you check CS - I think if() needs a space after the f. >------------ OK! >is _pre() actualy used anywhere? > _pre() is used by several test methods to give out the contents of an array. It's replaced with the RELEASE_1_2_0. >----------------- >Is PEAR_Exception not the standard now? > I don't know. But i will have a look. Thx for giving me a peek. Regards Markus Niewerth