[PEPr] Comment on Encryption::Crypt_DES

David Sanders (http://pear.php.net/user/shangxiao) has commented on the proposal for Encryption::Crypt_DES. Comment: All new packages should be written for only php 5 in mind ;) (So that means var -> public/private, define -> const etc) I'm not up to speed with encryption algorithms and libraries and I'm not sure if it would make much difference but it might be an idea to provide the user with the ability to choose whether to always use the internal implementation for consistency. Other than that it looks pretty clean and easy to read... I'll read through it in more detail when I get some time ;) Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=486 -- Sent by PEPr, the automatic proposal system at http://pear.php.net