[PEPr] Comment on Encryption::Crypt_DES
| From: | Jan Schneider | Date: | Tue, 08 May 2007 09:47:40 +0000 |
| Subject: | [PEPr] Comment on Encryption::Crypt_DES | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-46663@lists.php.net to get a copy of this message | ||
Jan Schneider (http://pear.php.net/user/yunosh) has commented on the proposal for
Encryption::Crypt_DES.
Comment:
Very nice code. And I don't agree with David regarding the mcrypt
integration, but that's nit picking anyway. Giving the user the option to
choose the encryption engine doesn't hurt anyone.
You should add a few unit tests to the package before calling for votes,
should be easy enough.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=486
--
Sent by PEPr, the automatic proposal system at http://pear.php.net