[PEPr] +1 for Networking::Net_Vpopmaild

From: Date: Sat, 10 Nov 2007 22:28:05 +0000
Subject: [PEPr] +1 for Networking::Net_Vpopmaild
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-48427@lists.php.net to get a copy of this message
Christian Weiske (http://pear.php.net/user/cweiske) has voted +1 on the proposal for Networking::Net_Vpopmaild. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=516 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=516&handle=cweiske This vote is conditional. The condition is: - Run PHP_CodeSniffer on the package sources to find coding style problems - The class is really big, too big in my eyes. Perhaps the functionality could be grouped into subclasses, with a base class that implements the daemon communitcation functionality. - If I understood correctly, the daemon can be accessed over network. This also means that the client can be run on a windows system. "/tmp/" as directory for log files is invalid in this case. PEAR's System class has methods to retrieve the tmp path. - The docblocks are mostly without content. Proper parameter and function descriptions are needed. - Maybe a mock server could be used for tests when no real server is available. Further, config.php should not be installed by pear but a file like "config.php.dist" that the user needs to copy and setup to config.php first. Further, the tests should be skipped if no config is setup. -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#48427) next »