Re: Re: [PEPr] +1 for Networking::Net_Vpopmaild

On Nov 10, 2007, at 5:52 PM, Bill Shupp wrote:

On Nov 10, 2007, at 2:28 PM, Christian Weiske wrote:

This vote is conditional. The condition is:

Ok, I believe I've addressed all the items in your condition (aside from optional idea of a mock vpopmaild server). Please have a look here: http://shupp.org/Net_Vpopmaild (you can grab the newer 0.0.3 version there, but I can't modify the proposal since it's in the voting stage) The changes are: * Split Class into Net_Vpopmaild_Base and Net_Vpopmaild. The latter implements the vpopmaild commands, the former sets up the connection, provides status checking and a couple of other helper methods used by the main Net_Vpopmaild methods. * Coding standard fixes. All php files no longer produce errors from PHP_CodeSniffer. Document Blocks are all populated now as well. * Use System::tmpdir() and PATH_SEPARATOR for auto generation of a log file location. * Remove parseHomeDotqmail(), which belongs in the application I'm writing, not this class. (remove related test as well) * Remove Validate dependency, it was used by the above method. * Rename tests-config.php and tests-setpath.php to have .dist extentions appended. So by default, all tests are skipped. If either of the files (with .php extensions only) are missing, all still skipped. In order to run tests, you must copy/mv these files to not have the .dist extension (and subsequently configure them to match your test environment). Currently, all tests pass for me, and all tests also successfully skip when the above environment is not configured. Thanks for your feedback, Christian. This process is certainly increasing the quality of this package. Would anyone else care to vote? :) Regards, Bill Shupp