Re: [PEPr] +1 for Networking::Net_Vpopmaild

On Nov 10, 2007, at 2:28 PM, Christian Weiske wrote:

This vote is conditional. The condition is: - Run PHP_CodeSniffer on the package sources to find coding style problems

Ok, these will be easy to fix.

- The class is really big, too big in my eyes. Perhaps the functionality could be grouped into subclasses, with a base class that implements the daemon communitcation functionality.

Yeah, I've felt that is was too big as well. I could easily move the networking stuff into Net_Vpopmaild_Base, and maybe also put status checking or other common methods in there (file and directory methods, for example). But I'll have to put some thought into sub-grouping the other methods if I want to avoid having everything instantiated at once.

- If I understood correctly, the daemon can be accessed over network. This also means that the client can be run on a windows system. "/tmp/" as directory for log files is invalid in this case. PEAR's System class has methods to retrieve the tmp path.

Great idea.

- The docblocks are mostly without content. Proper parameter and function descriptions are needed.

Agreed.

- Maybe a mock server could be used for tests when no real server is available.

This is not a bad idea, but could be a lot of work emulating all the vpopmaild functions.

Further, config.php should not be installed by pear but a file like "config.php.dist" that the user needs to copy and setup to config.php first.

I thought about this too, I'll make the change.

Further, the tests should be skipped if no config is setup.

Can you do that with pear run-tests and phpt files? Regards, Bill Shupp