Re: QA with PHPUnit test script and PHP_CodeSniffer ...with a bit of new of Services_W3C_CSSValidator
| From: | Laurent Laville | Date: | Tue, 20 Nov 2007 15:40:29 +0000 |
| Subject: | Re: QA with PHPUnit test script and PHP_CodeSniffer ...with a bit of new of Services_W3C_CSSValidator | ||
| References: | 1 2 3 4 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-48503@lists.php.net to get a copy of this message | ||
Christian Weiske a écrit :
Laurent,I understand your point of view, but we are in front (again) of a coding standard exception. See page of manual [1] about constant. [1] http://pear.php.net/manual/en/standards.naming.php#AEN1215Due to implementation of Christian script [1] and its impact on all others, don't forget this main piece of puzzle.I kept the constant name as it was because the PHPUnit test skeleton generator generates it that way, and who am I to ask all developers to change their tests? In my opionion we should keep it the way it is - as phpunit generates it. If we don't, we'll always have problems with new code of new (or old) developers that don't remember that rule. Christian,