Re: QA with PHPUnit test script and PHP_CodeSniffer ...with a bit of new of Services_W3C_CSSValidator

On Nov 20, 2007 9:40 AM, Laurent Laville <pear@laurent-laville.org> wrote: > Christian Weiske a écrit : > > Laurent, > > > > > >> Due to implementation of Christian script [1] and its impact on all > >> others, don't forget this main piece of puzzle. > > > > I kept the constant name as it was because the PHPUnit test skeleton > generator generates it that way, and who am I to ask all developers to > change their tests? > > > > In my opionion we should keep it the way it is - as phpunit generates > it. If we don't, we'll always have problems with new code of new (or old) > developers that don't remember that rule. > > > > > Christian, > > I understand your point of view, but we are in front (again) of a coding > standard exception. See page of manual [1] about constant. > > [1] http://pear.php.net/manual/en/standards.naming.php#AEN1215 > True, and as use of code generator tools increases, we'll have the same question if those generators create constants like this. The question then becomes whether or not we bend the standards to fit the tools, or bend the resulting code to fit the standards. -- CRB Let me introduce you to my very own DMCA-protected encryption key: BC 1B 64 4A 8D DE 49 E8 C3 7D CC EE 1A AD EE F5 (compliments of Freedom-to-Tinker http://www.freedom-to-tinker.com/?p=1155)