Re: QA with PHPUnit test script and PHP_CodeSniffer ...with a bit of new of Services_W3C_CSSValidator

Hi, Chuck Burgess wrote:

In my opionion we should keep it the way it is - as phpunit generates

it. If we don't, we'll always have problems with new code of new (or old) developers that don't remember that rule.

Christian, I understand your point of view, but we are in front (again) of a coding standard exception. See page of manual [1] about constant. [1] http://pear.php.net/manual/en/standards.naming.php#AEN1215

True, and as use of code generator tools increases, we'll have the same question if those generators create constants like this. The question then becomes whether or not we bend the standards to fit the tools, or bend the resulting code to fit the standards.

Ooohkay, if you put it that way then I suggest making an exception for PHPunit in the standards. That'll be better than making PEAR's PHPUnit tests incompatible with PHPUnit tests from everywhere else.