Re: QA with PHPUnit test script and PHP_CodeSniffer ...with a bit of new of Services_W3C_CSSValidator
| From: | till | Date: | Tue, 20 Nov 2007 22:00:38 +0000 |
| Subject: | Re: QA with PHPUnit test script and PHP_CodeSniffer ...with a bit of new of Services_W3C_CSSValidator | ||
| References: | 1 2 3 4 5 6 7 8 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-48527@lists.php.net to get a copy of this message | ||
On Nov 20, 2007 4:54 PM, Alexey Borzov <borz_off@cs.msu.su> wrote:
> Hi,
>
> Christian Weiske wrote:
> >> True, and as use of code generator tools increases, we'll have the
> >> same question if those generators create constants like this. The
> >> question then becomes whether or not we bend the standards to fit the
> >> tools, or bend the resulting code to fit the standards.
> > Ok, then we will change it to our CS.
> >
> > Would someone volunteer and fix it in whole CVS?
> > You've got my permission for all packages I maintain.
>
> It is an extremely bad idea, since people may call PEAR's unit test suites from
> their own unit tests suites. I think we should follow PHPUnit's "coding
> standard" rather than impose our own.
Maybe ask SB to change that in the long run. Like with a new major
version - or to support both. ;)