Re: QA with PHPUnit test script and PHP_CodeSniffer ...witha bit of new of Services_W3C_CSSValidator

Alexey Borzov wrote: > Hi, > > Christian Weiske wrote: >>> True, and as use of code generator tools increases, we'll have the >>> same question if those generators create constants like this. The >>> question then becomes whether or not we bend the standards to fit the >>> tools, or bend the resulting code to fit the standards. >> Ok, then we will change it to our CS. >> >> Would someone volunteer and fix it in whole CVS? >> You've got my permission for all packages I maintain. > > It is an extremely bad idea, since people may call PEAR's unit test > suites from their own unit tests suites. I think we should follow > PHPUnit's "coding standard" rather than impose our own. I agree 100% - we must remember that PEAR doesn't control external tools, to think otherwise is a bit like the way the USA government seems to think about foreign policy, and leads to much unnecessary bloodshed. Let's keep things smarter than that in PEAR. Greg