Re: QA with PHPUnit test script and PHP_CodeSniffer ...with a bit of new of Services_W3C_CSSValidator

On Nov 20, 2007 3:54 PM, Alexey Borzov <borz_off@cs.msu.su> wrote: > Hi, > > Christian Weiske wrote: > >> True, and as use of code generator tools increases, we'll have the > >> same question if those generators create constants like this. The > >> question then becomes whether or not we bend the standards to fit the > >> tools, or bend the resulting code to fit the standards. > > Ok, then we will change it to our CS. > > > > Would someone volunteer and fix it in whole CVS? > > You've got my permission for all packages I maintain. > > It is an extremely bad idea, since people may call PEAR's unit test suites > from > their own unit tests suites. I think we should follow PHPUnit's "coding > standard" rather than impose our own. > There seem to be good points on all sides of this discussion. Perhaps what we want to do will be to state that the CS only applies to the true code in your package, and not extraneous stuff like tests, examples, etc. -- CRB Let me introduce you to my very own DMCA-protected encryption key: BC 1B 64 4A 8D DE 49 E8 C3 7D CC EE 1A AD EE F5 (compliments of Freedom-to-Tinker http://www.freedom-to-tinker.com/?p=1155)