Re: [PEPr] +1 for File System::File_Mogile

By 'binary case' I meant 'binary cast'. On Wed, 2008-09-04 at 20:34 +0000, Michael Gauthier wrote: > Michael Gauthier (http://pear.php.net/user/gauthierm) has voted +1 on the proposal for File > System::File_Mogile. > > Proposal information: > http://pear.php.net/pepr/pepr-proposal-show.php?id=528 > Vote information: > > http://pear.php.net/pepr/pepr-vote-show.php?id=528&handle=gauthierm > > Comment: > > Looks cool. I like the use of the php://temp stream. > > - mb_strlen() should only be used after checking extension_loaded(). > Regular strlen() should be used if the extension is not loaded or add a new > extension dependency to the package. You can make this forwards compatible > by using a binary case. > - exception class documentation references Services_Digg > - class and file-level docblock lines should be indented by one space. ' * > ', not '* '. > - class level documentation is missing and just repeats the class name > - contrary to the docs, the destructor can't throw an exception > - if the destructor is called after failure to connect to a tracker, > fclose() will be called on false. This will raise an E_WARNING > - dependency on Validate is missing in package.xml > > -- > Sent by PEPr, the automatic proposal system at > http://pear.php.net >