Re: Re: [PEPr] +1 for File System::File_Mogile

Steve, the test[s] that you do have aren't referenced in the package.xml This means that anybody that might want to contribute to your package once it has been accepted won't have access to the test and won't be able to tell whether or not their work has introduced a bug unless they have access to the repository where the test file is stored and that mightn't always be the case. As regards that test you provided, it is using a mock address of example.comwhich can't be reached and results in the test failing: [kguest@kguest-desktop File_Mogile-0.0.7]$ pear run-tests File_Mogile_Basic.phpt Running 1 tests FAIL File_Mogile Basic Test[File_Mogile_Basic.phpt] wrote log to "/home/kguest/File_Mogile-0.0.7/run-tests.log" TOTAL TIME: 00:00 0 PASSED TESTS 0 SKIPPED TESTS 1 FAILED TESTS: File_Mogile_Basic.phpt [kguest@kguest-desktop File_Mogile-0.0.7]$ cat File_Mogile_Basic.log ---- EXPECTED OUTPUT I am the walrus. ---- ACTUAL OUTPUT Warning: fsockopen(): php_network_getaddresses: getaddrinfo failed: Name or service not known in /home/kguest/cf/File_Mogile-0.0.7/File/Mogile.php on line 118 Warning: fsockopen(): unable to connect to host1.example.com:7001 (Unknown error) in /home/kguest/cf/File_Mogile-0.0.7/File/Mogile.php on line 118 Warning: fsockopen(): php_network_getaddresses: getaddrinfo failed: Name or service not known in /home/kguest/cf/File_Mogile-0.0.7/File/Mogile.php on line 118 Warning: fsockopen(): unable to connect to host2.example.com:7001 (Unknown error) in /home/kguest/cf/File_Mogile-0.0.7/File/Mogile.php on line 118 File_Mogile_Exception: Unable to connect to tracker in /home/kguest/cf/File_Mogile-0.0.7/File_Mogile_Basic.php on line 17 #0 /home/kguest/cf/File_Mogile-0.0.7/File_Mogile_Basic.php(17): File_Mogile->__construct(Array, 'myMogileDomain', Array) #1 {main} ---- FAILED On Thu, Apr 10, 2008 at 1:10 AM, Steve Williams <sbw@digg.com> wrote: > At 03:50 PM 4/9/2008, Ken Guest wrote: > > > don't forget to include the tests in the package! > > > > There's one test in there: > > http://www.sbw.org/File_Mogile/tests/ > > Should I have pointed to the test in a different way in the proposal? > > I realize I could have done more tests. > > -- > PEAR Development Mailing List (http://pear.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > >