Re: Re: [PEPr] +1 for File System::File_Mogile
| From: | Michael Gauthier | Date: | Thu, 10 Apr 2008 02:08:09 +0000 |
| Subject: | Re: Re: [PEPr] +1 for File System::File_Mogile | ||
| References: | 1 2 3 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-49731@lists.php.net to get a copy of this message | ||
On Wed, 2008-09-04 at 14:53 -0700, Steve Williams wrote:
> At 01:34 PM 4/9/2008, Michael Gauthier wrote:
> >- mb_strlen() should only be used after checking extension_loaded().
>
> Oh, right. Thanks.
>
> >You can make this forwards compatible by using a binary cast.
>
> Sorry, what's a "binary cast"?
>
A binary cast is: strlen((binary)$string). This ensures you're counting
bytes when PHP supports unicode strings.
> >- class and file-level docblock lines should be indented by one
> >space. ' * ', not '* '.
>
> Um ... OK. I applied phpcs and got no warnings, but I'll take
> another look at that.
I was reviewing the phps file here:
http://www.sbw.org/File_Mogile/File/Mogile.phps.
The sources in the tgz
archive do not have this problem.