[PEPr] Comment on Configuration::Config_Lite
| From: | Till Klampaeckel | Date: | Thu, 09 Sep 2010 18:02:47 +0000 |
| Subject: | [PEPr] Comment on Configuration::Config_Lite | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-53784@lists.php.net to get a copy of this message | ||
Great,
I'd really like to see this in pear. Extra bonus points for tests. And here
is some feedback:
1) Use exceptions:
Config_Lite_Exception extends PEAR_Exception {}
... and then "throw new Config_Lite_Exception('message');" (vs. the aged
PEAR_Error).
2) Only require PEAR_Exception
3) Improve error handling (e.g. the return from parse_ini_file, if the file
exists, etc.)
4) Run PHP_CodeSniffer
5) Add an AllTests.php file - see other packages for examples.
6) Add the package.xml to your download. (Don't forget "pear
package-validate" to check and "pear package" to produce the tarball.)
Let me know if this helps, or if I can help.
Till
--
http://pear.php.net/pepr/pepr-proposal-show.php?id=645