Re: Re: [PEPr] Comment on Configuration::Config_Lite
| From: | Christian Weiske | Date: | Thu, 06 Jan 2011 08:40:41 +0000 |
| Subject: | Re: Re: [PEPr] Comment on Configuration::Config_Lite | ||
| References: | 1 2 3 4 5 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-53945@lists.php.net to get a copy of this message | ||
Hi Patrick,
> But Warnings when running phpcs without any options (--standard=PEAR)
>
> ╭─[~/gitrepos/config_lite/config_lite/Config]─[pce@agamemnon]
> ╰─[:)] % phpcs Lite.php
>
> FILE: /home/pce/gitrepos/config_lite/config_lite/Config/Lite.php
> --------------------------------------------------------------------------------
> FOUND 0 ERROR(S) AND 16 WARNING(S) AFFECTING 16 LINE(S)
> --------------------------------------------------------------------------------
> 13 | WARNING | Invalid version "Release: @package_version@" in file
> comment; | | consider "CVS: <cvs_id>" or "SVN:
> <svn_id>"
> instead 81 | WARNING | Line exceeds 85 characters; contains 87
> characters 85 | WARNING | Line exceeds 85 characters; contains 101
> ...
I see that you put the exception throwing on one line because phpcs
complained about it. You may however do that in PEAR with and function
call:
----
class foo
{
function bar()
{
$var = function(
$param1, $param2,
$param3paramparamparam,
$par4
);
}
}
----
this is valid an help you reduce line length.
The first problem is also solvable (invalid version). The file docblock
does not contain any release versions, only the svn id. Put the release
version in the class docblock:
----
<?php
/**
*...
* @version SVN: $...$
*/
/**
* ..
* @version @@package_version@@
*/
class foo
...
----
--
Regards/Mit freundlichen Grüßen
Christian Weiske
-= Geeking around in the name of science since 1982 =-