Re: Re: [PEPr] Comment on Configuration::Config_Lite

Hi Christian, > Phpcs is an application, config_lite is a library. That's a huge difference. ok, that makes sense. > is that after your latest changes now? Yes, ╭─[~/gitrepos/config_lite/config_lite/Config]─[pce@agamemnon] ╰─[:(] % phpcs -n --standard=PEAR Lite.php But Warnings when running phpcs without any options (--standard=PEAR) ╭─[~/gitrepos/config_lite/config_lite/Config]─[pce@agamemnon] ╰─[:)] % phpcs Lite.php FILE: /home/pce/gitrepos/config_lite/config_lite/Config/Lite.php -------------------------------------------------------------------------------- FOUND 0 ERROR(S) AND 16 WARNING(S) AFFECTING 16 LINE(S) -------------------------------------------------------------------------------- 13 | WARNING | Invalid version "Release: @package_version@" in file comment; | | consider "CVS: <cvs_id>" or "SVN: <svn_id>" instead 81 | WARNING | Line exceeds 85 characters; contains 87 characters 85 | WARNING | Line exceeds 85 characters; contains 101 characters 201 | WARNING | Line exceeds 85 characters; contains 114 characters 204 | WARNING | Line exceeds 85 characters; contains 102 characters 231 | WARNING | Line exceeds 85 characters; contains 130 characters 251 | WARNING | Line exceeds 85 characters; contains 101 characters 259 | WARNING | Line exceeds 85 characters; contains 98 characters 286 | WARNING | Line exceeds 85 characters; contains 98 characters 304 | WARNING | Line exceeds 85 characters; contains 134 characters 312 | WARNING | Line exceeds 85 characters; contains 131 characters 320 | WARNING | Line exceeds 85 characters; contains 101 characters 338 | WARNING | Line exceeds 85 characters; contains 101 characters 346 | WARNING | Line exceeds 85 characters; contains 102 characters 443 | WARNING | Line exceeds 85 characters; contains 101 characters 466 | WARNING | Line exceeds 85 characters; contains 101 characters -------------------------------------------------------------------------------- -- best Regards, Patrick On Wed, Jan 5, 2011 at 9:26 PM, Christian Weiske <cweiske@cweiske.de> wrote: > Hi patrick, > > >> > - you may not register your own autoloader. >> >> Why? I have this Code from the PEAR `PHP_CodeSniffer' package by >> Greg Sherwood and Marc McIntyre. >> There should be no collision with other autoloaders, registered with >> spl_autoload_register. > > Phpcs is an application, config_lite is a library. That's a huge difference. > >> > - run phpcs on the code >> ╭─[~/gitrepos/config_lite/config_lite/Config]─[pce@agamemnon] >> ╰─[:(] % phpcs -n --standard=PEAR Lite.php >> ╭─[~/gitrepos/config_lite/config_lite/Config]─[pce@agamemnon] >> ╰─[:)] % > is that after your latest changes now? > > > > Christian >