[PEPr] +1 for Configuration::Config_Lite
| From: | Michael Gauthier | Date: | Tue, 18 Jan 2011 20:40:54 +0000 |
| Subject: | [PEPr] +1 for Configuration::Config_Lite | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-54005@lists.php.net to get a copy of this message | ||
Michael Gauthier (http://pear.php.net/user/gauthierm) has voted +1 on the proposal for
Configuration::Config_Lite.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=645
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=645&handle=gauthierm
Comment:
Code looks great. You've improved it considerably since your initial
proposal.
I'd still like to see better property and method documentation in the
docblocks. Having the property or method name as the first line in a
docblock is pretty much useless as the generated documentation index will
look like:
- $foo -foo
- bar() - bar
- baz() - baz
It's much better to have a short descriptive sentence like
- $foo - Contains the foo for bar
- bar() - Bars the foo
- baz() - Inverts the foo